Wikipedia:Bots/Requests for approval/NihiltresBot

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Withdrawn by operator.

NihiltresBot[edit]

Operator: Nihiltres (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 21:01, Tuesday, May 17, 2016 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): AutoWikiBrowser

Source code available: AWB

Function overview: Adds " (disambiguation)", if appropriate, to parameter 1 of transclusions of {{other places}}.

Links to relevant discussions (where appropriate): Wikipedia:Village pump (technical)#Template:other people

Edit period(s): One-time run

Estimated number of pages affected: 13,000

Exclusion compliant (Yes/No): Yes, via AWB

Already has a bot flag (Yes/No): No

Function details: When converting {{other places}} to use Lua, I made a mistake, and parameter 1 no longer has " (disambiguation)" appended to it when defined. However, this change in behaviour is desirable for consistency, because none of the other "other X" templates force the parenthetical. That given, intended links to disambiguation pages should include the parenthetical to mark them as such, to make it easier to fix the unintended cases, and my mistake has caused some pages to link directly to disambiguation pages rather than through their "(disambiguation)" redirect.

The plan for this one-off task is to go through pages transcluding {{other places}} and replace the regex \{\{\s*other places\s*\|\s*([^\|\{\}]*)\}\} with the text {{other places|{{subst:#ifeq:{{subst:#invoke:Redirect|main|$1 (disambiguation)}}|$1|$1 (disambiguation)|$1}}}}. This should safely apply the disambiguation parenthetical, where appropriate, upon save. With AWB providing the framework, it's trivial to implement. As wikitext, {{other places}} only supported one parameter, so the regex as written should fix all the cases.

{{Other places}} is transcluded slightly over 21,000 times, of which slightly over 8,000 are transclusions of the merged {{other places3}}, whose functionality isn't affected by my mistake.

Discussion[edit]

{{BotTrial}} Link your edit summaries to this request please. — xaosflux ^Talk 23:50, 17 May 2016 (UTC)[reply]

{{BotTrialComplete}} Or at least, it submitted edits 40 times; some cases substituted themselves into null edits. Where the substituted wikitext parses out to nothing, the bot can end up making a harmless tweak to the capitalization of the template call ({{Other places}} → {{other places}}) without any other changes. I can tweak that so that it leaves the capitalization alone (making such changes null). {{Nihiltres |talk |edits}} 03:34, 18 May 2016 (UTC)[reply]

Some of your edits appeared to need adjusting: Kangaroo Island , Tarnów , Valparaíso. As you mentioned above, the capitalization change only on the first letter of the template name isn't needed - so please remove that part. After reviewing these items and making adjustments, please make another trial run. — xaosflux ^Talk 14:01, 19 May 2016 (UTC)[reply]

{{BotTrial}} — xaosflux ^Talk 14:01, 19 May 2016 (UTC)[reply]

Comment @Xaosflux and Nihiltres: based on what the recent disambiguation list looks like for May 17th (the day after the Lua change was made), it appears that this task has already been completed. A little investigation found that R'n'B's bot Russbot made the changes per one of its long-standing tasks (Wikipedia:Bots/Requests for approval/RussBot 4). -Niceguyedc ^{Go Huskies!} 09:22, 21 May 2016 (UTC)[reply]

{{OperatorAssistanceNeeded}} Nihiltres, is this task still required? — xaosflux ^Talk 12:14, 21 May 2016 (UTC)[reply]

This request will be moving to expired tomorrow, baring any updates. If it does expire, you may re-request at any time. — xaosflux ^Talk 23:17, 30 May 2016 (UTC)[reply]

Withdrawn by operator. Definitely redundant to the Russbot task. {{Nihiltres |talk |edits}} 16:40, 31 May 2016 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.